Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts-pro] Fix props and automatic documentation on BarChartPro and LineChartPro #14391

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

JCQuintas
Copy link
Member

It seems adding components after the main component of a file makes our proptypes/automatic documentation scripts break and not fully populate the correct props.

Moving the components to the top of the file fixes the issue.

@JCQuintas JCQuintas added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Aug 29, 2024
@JCQuintas JCQuintas self-assigned this Aug 29, 2024
@mui-bot
Copy link

mui-bot commented Aug 29, 2024

Deploy preview: https://deploy-preview-14391--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 4271156

Copy link

codspeed-hq bot commented Aug 29, 2024

CodSpeed Performance Report

Merging #14391 will not alter performance

Comparing JCQuintas:fix-proptype-generation (4271156) with master (3d767ba)

Summary

✅ 3 untouched benchmarks

@JCQuintas JCQuintas merged commit 5249349 into mui:master Aug 30, 2024
23 checks passed
@JCQuintas JCQuintas deleted the fix-proptype-generation branch August 30, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants